Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new gRPC default port #1725

Merged
merged 15 commits into from
Dec 21, 2020
Merged

Conversation

jufab
Copy link
Contributor

@jufab jufab commented Dec 4, 2020

Which problem is this PR solving?

New Default gRPC OTEL Default port.

Short description of the changes

Use new gRPC Otel default port => open-telemetry/opentelemetry-specification#1221

@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #1725 (42ed391) into master (c1d4264) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1725      +/-   ##
==========================================
- Coverage   92.11%   92.09%   -0.02%     
==========================================
  Files         166      166              
  Lines        5591     5591              
  Branches     1198     1198              
==========================================
- Hits         5150     5149       -1     
- Misses        441      442       +1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test that our collector exporter is compatible with the 0.16 version of the collector ?

@jufab
Copy link
Contributor Author

jufab commented Dec 5, 2020

@vmarchaud I used examples/collector-exporter-node to test my modification and I update collector version (0.16.0):

  • I modified tracing.js and metrics.js to use grpc exporter
  • I modified in node_modules (@opentelemetry/exporter-collector-grpc ) exporter with new default port (4317)
  • After launch docker, metrics.js and tracing.js, I verified in prometheus and zipkin.

And everything is OK.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this change according to spec should be also applied to the rest of collectors as port 55680 is gone
Please update also each README.md with information of last used version of collector (it is in top of the readme)

@jufab
Copy link
Contributor Author

jufab commented Dec 8, 2020

@obecny It's done.

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the build

@dyladan dyladan added the bug Something isn't working label Dec 21, 2020
@dyladan
Copy link
Member

dyladan commented Dec 21, 2020

@jufab if you fix the lint I can merge this

@jufab
Copy link
Contributor Author

jufab commented Dec 21, 2020

@jufab if you fix the lint I can merge this

I have a problem with the linter.

Example

this error :
lint-error

I fix it manually

manual-fix

I run npm run lint:fix, and after that, I have

autofix

What's wrong with linter? I have no idea.
Can you help me?

@dyladan
Copy link
Member

dyladan commented Dec 21, 2020

You probably have an out-of-date version of the linting dependencies. I would do lerna clean -y and lerna bootstrap again and see if that fixes it.

@jufab
Copy link
Contributor Author

jufab commented Dec 21, 2020

I tried without success so I reinstalled all.
😊

@dyladan dyladan merged commit 16a3316 into open-telemetry:master Dec 21, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants