Merge branch 'master' into batch_span_processor

open-telemetry · Sep 24, 2019 · 2664258 · 2664258
2 parents f14d8e7 + 0024d0a
commit 2664258
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/packages/opentelemetry-exporter-jaeger/README.md b/packages/opentelemetry-exporter-jaeger/README.md
@@ -74,11 +74,12 @@ tracer.addSpanProcessor(new BatchSpanProcessor(exporter));
 
 You can use built-in `SimpleSpanProcessor` or `BatchSpanProcessor` or write your own.
 
-- SimpleSpanProcessor: The implementation of `SpanProcessor` that passes ended span directly to the configured `SpanExporter`.
-- BatchSpanProcessor: The implementation of the `SpanProcessor` that batches ended spans and pushes them to the configured `SpanExporter`. It is recommended to use this `SpanProcessor` for better performance and optimization.
+- [SimpleSpanProcessor](https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-tracing.md#simple-processor): The implementation of `SpanProcessor` that passes ended span directly to the configured `SpanExporter`.
+- [BatchSpanProcessor](https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-tracing.md#batching-processor): The implementation of the `SpanProcessor` that batches ended spans and pushes them to the configured `SpanExporter`. It is recommended to use this `SpanProcessor` for better performance and optimization.
 
 
 ## Useful links
+- To know more about Jaeger, visit: https://www.jaegertracing.io/docs/latest/getting-started/
 - For more information on OpenTelemetry, visit: <https://opentelemetry.io/>
 - For more about OpenTelemetry JavaScript: <https://github.com/open-telemetry/opentelemetry-js>
 - For help or feedback on this project, join us on [gitter][gitter-url]

diff --git a/packages/opentelemetry-exporter-zipkin/README.md b/packages/opentelemetry-exporter-zipkin/README.md
@@ -38,8 +38,8 @@ tracer.addSpanProcessor(new BatchSpanProcessor(exporter));
 
 You can use built-in `SimpleSpanProcessor` or `BatchSpanProcessor` or write your own.
 
-- SimpleSpanProcessor: The implementation of `SpanProcessor` that passes ended span directly to the configured `SpanExporter`.
-- BatchSpanProcessor: The implementation of the `SpanProcessor` that batches ended spans and pushes them to the configured `SpanExporter`. It is recommended to use this `SpanProcessor` for better performance and optimization.
+- [SimpleSpanProcessor](https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-tracing.md#simple-processor): The implementation of `SpanProcessor` that passes ended span directly to the configured `SpanExporter`.
+- [BatchSpanProcessor](https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-tracing.md#batching-processor): The implementation of the `SpanProcessor` that batches ended spans and pushes them to the configured `SpanExporter`. It is recommended to use this `SpanProcessor` for better performance and optimization.
 
 ## Viewing your traces
 

diff --git a/packages/opentelemetry-plugin-grpc/package.json b/packages/opentelemetry-plugin-grpc/package.json
@@ -40,7 +40,6 @@
   "devDependencies": {
     "@types/mocha": "^5.2.7",
     "@types/node": "^12.6.9",
-    "@types/protobufjs": "^6.0.0",
     "@types/shimmer": "^1.0.1",
     "codecov": "^3.5.0",
     "grpc": "^1.23.3",