feat(semantic-conventions): add missing RpcAttributes from spec (#1976)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
open-telemetry · Mar 2, 2021 · 41235a9 · 41235a9
1 parent 4c609aa
commit 41235a9
Showing 1 changed file with 22 additions and 0 deletions.
diff --git a/packages/opentelemetry-semantic-conventions/src/trace/rpc.ts b/packages/opentelemetry-semantic-conventions/src/trace/rpc.ts
@@ -14,8 +14,30 @@
  * limitations under the License.
  */
 export const RpcAttribute = {
+ /**
+ * A string identifying the remoting system.
+ *
+ * @remarks
+ * Required
+ */
+ RPC_SYSTEM: 'rpc.system',
+
+ /**
+ * The full name of the service being called, including its package name, if applicable.
+ *
+ * @remarks
+ * Not required, but recommended
+ */
  RPC_SERVICE: 'rpc.service',
 
+ /**
+ * The name of the method being called, must be equal to the $method part in the span name.
+ *
+ * @remarks
+ * Not required, but recommended
+ */
+ RPC_METHOD: 'rpc.method',
+
  // GRPC (no spec)
  GRPC_KIND: 'grpc.kind', // SERVER or CLIENT
  GRPC_METHOD: 'grpc.method',