feat(opentelemetry-exporter-otlp-http): fix otlp http exporter

hold off on updating labels to attributes until the proto is updated
open-telemetry · Nov 4, 2021 · 4d65142 · 4d65142
1 parent 3b76c24
commit 4d65142
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/experimental/packages/opentelemetry-exporter-metrics-otlp-http/src/transformMetrics.ts b/experimental/packages/opentelemetry-exporter-metrics-otlp-http/src/transformMetrics.ts
@@ -15,7 +15,7 @@
  */
 
 import { SpanAttributes, HrTime } from '@opentelemetry/api';
-import { Labels, ValueType } from '@opentelemetry/api-metrics';
+import { Attributes as Labels, ValueType } from '@opentelemetry/api-metrics';
 import * as core from '@opentelemetry/core';
 import {
   AggregatorKind,
@@ -54,7 +54,7 @@ export function toAggregationTemporality(
 }
 
 /**
- * Returns an DataPoint which can have integers or doublle values
+ * Returns an DataPoint which can have integers or double values
  * @param metric
  * @param startTime
  */
@@ -63,7 +63,7 @@ export function toDataPoint(
   startTime: number
 ): otlpTypes.opentelemetryProto.metrics.v1.DataPoint {
   return {
-    labels: toCollectorLabels(metric.labels),
+    labels: toCollectorLabels(metric.attributes),
     value: metric.aggregator.toPoint().value as number,
     startTimeUnixNano: startTime,
     timeUnixNano: core.hrTimeToNanoseconds(
@@ -86,7 +86,7 @@ export function toHistogramPoint(
     timestamp: HrTime;
   };
   return {
-    labels: toCollectorLabels(metric.labels),
+    labels: toCollectorLabels(metric.attributes),
     sum: value.sum,
     count: value.count,
     startTimeUnixNano: startTime,

diff --git a/...al/packages/opentelemetry-exporter-metrics-otlp-http/test/common/transformMetrics.test.ts b/...al/packages/opentelemetry-exporter-metrics-otlp-http/test/common/transformMetrics.test.ts
@@ -158,7 +158,7 @@ describe('transformMetrics', () => {
       );
     });
 
-    it('should convert metric labels value to string', () => {
+    it('should convert metric attributes value to string', () => {
       const metric = transform.toCollectorMetric(
         {
           descriptor: {
@@ -168,7 +168,7 @@ describe('transformMetrics', () => {
             metricKind: 0,
             valueType: 0,
           },
-          labels: { foo: (1 as unknown) as string },
+          attributes: { foo: (1 as unknown) as string },
           aggregator: new SumAggregator(),
           resource: new Resource({}),
           aggregationTemporality: 0,