remove Detector and use DetectorSync

remove the Detector and use the DetectorSync instead. Also mark things as experimental.
open-telemetry · Apr 11, 2024 · 8628f8a · 8628f8a
1 parent 0abedfc
commit 8628f8a
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 56 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,7 +12,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
 ### :rocket: (Enhancement)
 
 * feat(sdk-trace-base): log resource attributes in ConsoleSpanExporter [#4605](https://github.com/open-telemetry/opentelemetry-js/pull/4605) @pichlermarc
-* feat(resources): new detector ServiceInstanceIDDetector that sets the value for `service.instance.id` as random UUID.
+* feat(resources): new experimental detector ServiceInstanceIDDetector that sets the value for `service.instance.id` as random UUID.
 
 ### :bug: (Bug Fix)
 

diff --git a/packages/opentelemetry-resources/src/platform/browser/ServiceInstanceIDDetector.ts b/packages/opentelemetry-resources/src/platform/browser/ServiceInstanceIDDetector.ts
diff --git a/packages/opentelemetry-resources/src/platform/browser/ServiceInstanceIDDetectorSync.ts b/packages/opentelemetry-resources/src/platform/browser/ServiceInstanceIDDetectorSync.ts
@@ -16,4 +16,7 @@
 
 import { noopDetectorSync } from '../../detectors/NoopDetectorSync';
 
-export const serviceInstanceIDDetectorSync = noopDetectorSync;
+/**
+ * @experimental
+ */
+export const serviceInstanceIDDetector = noopDetectorSync;
diff --git a/packages/opentelemetry-resources/src/platform/browser/index.ts b/packages/opentelemetry-resources/src/platform/browser/index.ts
@@ -21,4 +21,4 @@ export * from './HostDetectorSync';
 export * from './OSDetectorSync';
 export * from './ProcessDetector';
 export * from './ProcessDetectorSync';
-export * from './ServiceInstanceIDDetector';
+export * from './ServiceInstanceIDDetectorSync';
diff --git a/packages/opentelemetry-resources/src/platform/node/ServiceInstanceIDDetector.ts b/packages/opentelemetry-resources/src/platform/node/ServiceInstanceIDDetector.ts
diff --git a/packages/opentelemetry-resources/src/platform/node/ServiceInstanceIDDetectorSync.ts b/packages/opentelemetry-resources/src/platform/node/ServiceInstanceIDDetectorSync.ts
@@ -33,5 +33,7 @@ class ServiceInstanceIDDetectorSync implements DetectorSync {
   }
 }
 
-export const serviceInstanceIDDetectorSync =
-  new ServiceInstanceIDDetectorSync();
+/**
+ * @experimental
+ */
+export const serviceInstanceIDDetector = new ServiceInstanceIDDetectorSync();
diff --git a/packages/opentelemetry-resources/src/platform/node/index.ts b/packages/opentelemetry-resources/src/platform/node/index.ts
@@ -21,4 +21,4 @@ export * from './HostDetectorSync';
 export * from './OSDetectorSync';
 export * from './ProcessDetector';
 export * from './ProcessDetectorSync';
-export * from './ServiceInstanceIDDetector';
+export * from './ServiceInstanceIDDetectorSync';