Skip to content

Commit

Permalink
fix(ci): adapt workflow to use supported npm versions (#5277)
Browse files Browse the repository at this point in the history
  • Loading branch information
pichlermarc authored Dec 17, 2024
1 parent 84cce75 commit 8ab52d5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fail-fast: false
matrix:
node_version:
- "18"
- "22"
runs-on: self-hosted
timeout-minutes: 10
env:
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,16 @@ jobs:
node-version: ${{ matrix.node_version }}

- run: npm install -g npm@latest
if: ${{ matrix.node_version == '18' || matrix.node_version == '20' || matrix.node_version == '22' }}
if: ${{ matrix.node_version == '20' || matrix.node_version == '22' }}

# npm@10.0.0 drops support for Node.js v14 and v16
- run: npm install -g npm@"<10.0.0"
if: ${{ matrix.node_version == '14' || matrix.node_version == '16' }}

# npm@11.0.0 drops support for Node.js v18
- run: npm install -g npm@"<11.0.0"
if: ${{ matrix.node_version == '18'}}

- name: Bootstrap
run: npm ci

Expand Down Expand Up @@ -65,7 +69,7 @@ jobs:
cache: 'npm'
cache-dependency-path: |
package-lock.json
node-version: '18'
node-version: '20'

- run: npm install -g npm@latest

Expand Down

0 comments on commit 8ab52d5

Please sign in to comment.