fix: suggested changes

open-telemetry · May 26, 2023 · 922f2f3 · 922f2f3
1 parent 8bc44ae
commit 922f2f3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/...est/browser/CollectorLogsExporter.test.ts → ...oto/test/browser/OTLPLogsExporter.test.ts b/...est/browser/CollectorLogsExporter.test.ts → ...oto/test/browser/OTLPLogsExporter.test.ts
diff --git a/...al/packages/otlp-proto-exporter-base/src/platform/browser/OTLPProtoExporterBrowserBase.ts b/...al/packages/otlp-proto-exporter-base/src/platform/browser/OTLPProtoExporterBrowserBase.ts
@@ -25,12 +25,6 @@ import {
 
 import { getExportRequestProto } from '../util';
 
-interface ExportRequestType<T, R = T & { toJSON: () => unknown }> {
-  create(properties?: T): R;
-  encode(message: T, writer?: protobuf.Writer): protobuf.Writer;
-  decode(reader: protobuf.Reader | Uint8Array, length?: number): R;
-}
-
 /**
  * Collector Exporter abstract base class
  */
@@ -42,12 +36,6 @@ export abstract class OTLPProtoExporterBrowserBase<
     super(config);
   }
 
-  private _getExportRequestProto(
-    clientType: ServiceClientType
-  ): ExportRequestType<ServiceRequest> {
-    return getExportRequestProto(clientType);
-  }
-
   override send(
     objects: ExportItem[],
     onSuccess: () => void,
@@ -59,7 +47,7 @@ export abstract class OTLPProtoExporterBrowserBase<
     }
 
     const serviceRequest = this.convert(objects);
-    const exportRequestType = this._getExportRequestProto(
+    const exportRequestType = getExportRequestProto(
       this.getServiceClientType()
     );
     const message = exportRequestType.create(serviceRequest);