fix(instrumentation-xml-http-request): use previous parseUrl approach…

… as the new approach throws on relative paths.
open-telemetry · Apr 4, 2022 · a3078b6 · a3078b6
1 parent 97fe596
commit a3078b6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/experimental/packages/opentelemetry-instrumentation-xml-http-request/src/xhr.ts b/experimental/packages/opentelemetry-instrumentation-xml-http-request/src/xhr.ts
@@ -26,9 +26,9 @@ import { SemanticAttributes } from '@opentelemetry/semantic-conventions';
 import {
   addSpanNetworkEvents,
   getResource,
-  parseUrl,
   PerformanceTimingNames as PTN,
   shouldPropagateTraceHeaders,
+  URLLike
 } from '@opentelemetry/sdk-trace-web';
 import { EventNames } from './enums/EventNames';
 import {
@@ -40,6 +40,12 @@ import {
 import { VERSION } from './version';
 import { AttributeNames } from './enums/AttributeNames';
 
+function parseUrl(url: string): URLLike {
+  const element = document.createElement('a');
+  element.href = url;
+  return element;
+}
+
 // how long to wait for observer to collect information about resources
 // this is needed as event "load" is called before observer
 // hard to say how long it should really wait, seems like 300ms is

diff --git a/experimental/packages/opentelemetry-instrumentation-xml-http-request/test/xhr.test.ts b/experimental/packages/opentelemetry-instrumentation-xml-http-request/test/xhr.test.ts
@@ -29,7 +29,7 @@ import { SemanticAttributes } from '@opentelemetry/semantic-conventions';
 import {
   PerformanceTimingNames as PTN,
   WebTracerProvider,
-  parseUrl,
+  URLLike,
 } from '@opentelemetry/sdk-trace-web';
 import * as assert from 'assert';
 import * as sinon from 'sinon';
@@ -48,6 +48,12 @@ class DummySpanExporter implements tracing.SpanExporter {
   }
 }
 
+function parseUrl(url: string): URLLike {
+  const element = document.createElement('a');
+  element.href = url;
+  return element;
+}
+
 const XHR_TIMEOUT = 2000;
 
 const getData = (