revisit general semantic conventions #1395
Comments
|
I believe this will likely be solved when we use the code generator here open-telemetry/build-tools#5 |
|
I think a lot of the semantic convention stuff has been fixed? At least NET_PEER_SERVICE is PEER_SERVICE now so maybe this can be closed? @dyladan |
|
we now auto-generate our semantic conventions package so this should be done |
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this issue
Dec 15, 2023
…ry#1395) * fix(postgres): make the connect callback patched function to return the client object * fix(postgres): lint * fix(postgres): remove PgErrorCallback * fix(postgres): remove PgErrorCallback * fix(postgres): lint * fix(postgres): remove PgErrorCallback from connect() too * fix(postgres): chenge declaration of PgClientConnect --------- Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
opentelemetry-js/packages/opentelemetry-semantic-conventions/src/trace/general.ts
Line 29 in 88cd842
i.e. the above should not have the
NET_prefix as per https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/span-general.md#general-remote-service-attributesThe text was updated successfully, but these errors were encountered: