Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZipkinExporter] ExporterConfig needs to be exported since it is API #1453

Closed
BryanHunt opened this issue Aug 21, 2020 · 1 comment · Fixed by #1474
Closed

[ZipkinExporter] ExporterConfig needs to be exported since it is API #1453

BryanHunt opened this issue Aug 21, 2020 · 1 comment · Fixed by #1474
Assignees
@shivkanya9146
Labels
bug Something isn't working

Comments

@BryanHunt
Copy link

Please answer these questions before submitting a bug report.

What version of OpenTelemetry are you using?

0.10.2

What version of Node are you using?

14.8.0

What did you do?

import { ExporterConfig } from '@opentelemetry/exporter-zipkin';

What did you expect to see?

No errors

What did you see instead?

Module '"../node_modules/@opentelemetry/exporter-zipkin/build/src"' has no exported member 'ExporterConfig'.

Additional context

The ZipkinExporter constructor requires the type ExporterConfig which is not exported from the module. It should be exported since it is part of the API.
@BryanHunt BryanHunt added the bug Something isn't working label Aug 21, 2020
@shivkanya9146
Copy link
Contributor

I would like to work on this, please assign to me

@mayurkale22 mayurkale22 linked a pull request Aug 28, 2020 that will close this issue
chore(zipkin): export ExporterConfig #1474
Merged
@shivkanya9146 shivkanya9146 mentioned this issue Sep 2, 2020
Merged
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@haddasbronfman @Flarna
fix(pg-values): values should be parsable when enhancedDatabaseRepoti…
49a0389 
…ng:true (open-telemetry#1453)

* fix(pg-values): values should be parsable when enhancedDatabaseReporting:true

* fix(pg-values): add try catch

* fix(pg-values): lint

* fix(pg-values): fixes

* fix(pg-values): fix

* Update plugins/node/opentelemetry-instrumentation-pg/src/utils.ts

Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>

* fix(pg-values): support buffer, object, null and undefined

* Update plugins/node/opentelemetry-instrumentation-pg/src/utils.ts

Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>

* fix(pg-values): fixes

* fix(pg-values): lint

* fix(pg-values): add test for 'toPostgres'

* fix(pg-values): fix

---------

Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivkanya9146 shivkanya9146

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(zipkin): export ExporterConfig shivkanya9146/opentelemetry-js
2 participants
@BryanHunt @shivkanya9146