Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baggage as CORRELATION_CONTEXT_HEADER instead of otcorrelations #1578

Closed
Asafb26 opened this issue Oct 7, 2020 · 1 comment · Fixed by #1579
Closed

baggage as CORRELATION_CONTEXT_HEADER instead of otcorrelations #1578

Asafb26 opened this issue Oct 7, 2020 · 1 comment · Fixed by #1579
Assignees
Labels
bug Something isn't working

Comments

@Asafb26
Copy link
Contributor

Asafb26 commented Oct 7, 2020

Please answer these questions before submitting a bug report.

What version of OpenTelemetry are you using?

0.11

What version of Node are you using?

12

Please provide the code you used to setup the OpenTelemetry SDK

'use strict';

const opentelemetry = require("@opentelemetry/core")
const { NodeTracerProvider } = require("@opentelemetry/node")

const provider = new NodeTracerProvider({
    logLevel: opentelemetry.LogLevel.INFO
});

// Initialize the provider
provider.register();

Hello, I was planning to use open telemetry at my workspace but encounter an API issue between opentelemetry-ruby and opentelemetry-js - each of them uses a different header key to propagate the baggage items.

  • js uses otcorrelations - while this key was the specified key in OT specs, nowadays it changed to baggage
  • rb changed to baggage to sync with the latest specs.

Is there a way to override the CORRELATION_CONTEXT_HEADER key? or should I wait/open a PR for this?

@Asafb26 Asafb26 added the bug Something isn't working label Oct 7, 2020
@dyladan
Copy link
Member

dyladan commented Oct 8, 2020

Thanks for the PR. That is the correct way to solve it.

pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants