JaegerExporter sets error flag when span status is Unset

[debagger]

Please answer these questions before submitting a bug report.

What version of OpenTelemetry are you using?

"@opentelemetry/core": "^0.13.0",
"@opentelemetry/exporter-jaeger": "^0.13.0",
"@opentelemetry/node": "^0.13.0",
"@opentelemetry/plugin-dns": "^0.11.0",
"@opentelemetry/plugin-express": "^0.11.0",
"@opentelemetry/plugin-http": "^0.13.0",
"@opentelemetry/plugin-https": "^0.13.0",
"@opentelemetry/plugin-pg": "^0.11.0",
"@opentelemetry/plugin-pg-pool": "^0.11.0",
"@opentelemetry/tracing": "^0.13.0"

What version of Node are you using?

v15.4.0

Please provide the code you used to setup the OpenTelemetry SDK

import { LogLevel } from '@opentelemetry/core';
import { NodeTracerProvider } from '@opentelemetry/node';

import { SimpleSpanProcessor, BatchSpanProcessor } from '@opentelemetry/tracing';
// import { ZipkinExporter } from '@opentelemetry/exporter-zipkin';
// For Jaeger, use the following line instead:
import { JaegerExporter } from '@opentelemetry/exporter-jaeger';
export function initTracing() {
  const provider: NodeTracerProvider = new NodeTracerProvider({
    logLevel: LogLevel.INFO,
    plugins: {
      express: {
        enabled: true,
        // You may use a package name or absolute path to the file.
        path: '@opentelemetry/plugin-express',
      },
    },
  });

  provider.register();

  provider.addSpanProcessor(
    new BatchSpanProcessor(
    //   new ZipkinExporter({
        // For Jaeger, use the following line instead:
        new JaegerExporter({
        host: 'jaeger',
        port: 6832,
        serviceName: 'backstage',
        // If you are running your tracing backend on another host,
        // you can point to it using the `url` parameter of the
        // exporter config.
      }),
    ),
  );

  console.log('tracing initialized');
}

What did you do?

Send spans from express to jaeger

What did you expect to see?

Because of this ops finished successfully error tag must be false.

What did you see instead?

Get tag 'error' is true in Jaeger from @opentelemetry/plugin-express spans:

Additional context

I think the bug is here:

opentelemetry-js/packages/opentelemetry-exporter-jaeger/src/transform.ts

Line 58 in c478cc1

// Ensure that if Status.Code is not OK, that we set the "error" tag on the

If status code is UNSET its set error flag. But from api spec UNSET is normal.

When the status is set to ERROR by Instrumentation Libraries, the status codes SHOULD be documented and predictable. The status code should only be set to ERROR according to the rules defined within the semantic conventions. For operations not covered by the semantic conventions, Instrumentation Libraries SHOULD publish their own conventions, including status codes.

Generally, Instrumentation Libraries SHOULD NOT set the status code to Ok, unless explicitly configured to do so. Instrumention libraries SHOULD leave the status code as Unset unless there is an error, as described above.

Application developers and Operators may set the status code to Ok.

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/api.md

[debagger]

Issue fixed in v0.14.0 Release