Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semantic-conventions): add missing RpcAttributes from spec #1976

Merged
merged 2 commits into from
Mar 2, 2021
Merged

feat(semantic-conventions): add missing RpcAttributes from spec #1976

merged 2 commits into from
Mar 2, 2021

Conversation

blumamir
Copy link
Member

Which problem is this PR solving?

  • Adding 2 missing attributes to rpc semantic conventions, according to the specification. I need them to update the aws-sdk instrumentation according to these conventions

Short description of the changes

@codecov
Copy link

codecov bot commented Feb 28, 2021

Codecov Report

Merging #1976 (5be2c8c) into main (4c609aa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1976   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files         152      152           
  Lines        5922     5922           
  Branches     1245     1245           
=======================================
  Hits         5502     5502           
  Misses        420      420           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants