Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from lerna to nx #4240

Open
dyladan opened this issue Oct 30, 2023 · 4 comments
Open

Switch from lerna to nx #4240

dyladan opened this issue Oct 30, 2023 · 4 comments
Labels
never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@dyladan
Copy link
Member

dyladan commented Oct 30, 2023

We have used lerna for quite some time to manage our packages and builds, but for a while now it has just been a wrapper around nx which provides significant performance improvements. This has worked fine until now, but it is starting to cause problems because we can't control the version of nx which is used. In particular our testing of node 14 fails as can be seen in #4238

Switching to nx can avoid this issue, as well as reduce the likelihood of additional similar problems in the future. Additionally, it seems that we should be using the tooling directly rather than relying on a compatibility layer for an old and deprecated technology.

@dyladan dyladan added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Nov 8, 2023
@david-luna
Copy link
Contributor

Contrib repo migrated to use npm workspaces in open-telemetry/opentelemetry-js-contrib#1771 for package management and still using lerna for publishing. Is that an option?

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jan 29, 2024
Copy link

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
@david-luna
Copy link
Contributor

Some work already started in contrib open-telemetry/opentelemetry-js-contrib#2493

@david-luna david-luna reopened this Oct 22, 2024
@trentm trentm added never-stale and removed stale labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

No branches or pull requests

3 participants