Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[In Progress] Internal: lerna migration #4067

Closed

Conversation

clesleycode
Copy link

Which problem is this PR solving?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Short description of the changes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@dyladan
Copy link
Member

dyladan commented Aug 16, 2023

Hey @clesleycode thanks for working on this. Can you update the PR description with some of the concrete benefits you expect this to address? Will it speed up install times for example or is it just a matter of reducing our dependency load?

@clesleycode
Copy link
Author

Hey @clesleycode thanks for working on this. Can you update the PR description with some of the concrete benefits you expect this to address? Will it speed up install times for example or is it just a matter of reducing our dependency load?

This PR is a follow up from this issue. I'll add that context into the PR description, but should I elaborate more?

@pichlermarc
Copy link
Member

Thanks for working on this 🙂

Hey @clesleycode thanks for working on this. Can you update the PR description with some of the concrete benefits you expect this to address? Will it speed up install times for example or is it just a matter of reducing our dependency load?

This PR is a follow up from this issue. I'll add that context into the PR description, but should I elaborate more?

I think just putting a summary into the PR description that mentions that the lerna bootstrap polyfill in use right now is a temporary solution (and will be unsupported in the future) and linking to the lerna blog post would be fine 🙂

@pichlermarc
Copy link
Member

We don't need to remove lerna altogether, though. To fix #3927, we can still keep using it for versioning and such; just moving from lerna legacy package management to npm workspaces would accomplish the goal already. 🙂

@legendecas
Copy link
Member

Thank you for working on this! However, we've addressed the original issue when fixing a CI failure at #4238.

@legendecas legendecas closed this Nov 2, 2023
@legendecas
Copy link
Member

Yet, I believe we still need to remove lerna: #4240. If you are still interested in working on this, please feel free to re-open or open a new PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants