Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp-exporters] passing an undefined header values crashes end-user apps #4541

Closed
pichlermarc opened this issue Mar 12, 2024 · 0 comments · Fixed by #4540
Closed

[otlp-exporters] passing an undefined header values crashes end-user apps #4541

pichlermarc opened this issue Mar 12, 2024 · 0 comments · Fixed by #4540
Labels
bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc

Comments

@pichlermarc
Copy link
Member

pichlermarc commented Mar 12, 2024

What happened?

When passing an options object like { headers: { foo: undefined } } to the http/json and http/protobuf exporters, the headers will not be validated and that will cause

req = request(options, (res: http.IncomingMessage) => {

to throw, as we're passing an undefined header value. While this alone will not cause an application crash, trying to access req at

will cause the end-user's application to crash within typically 10s after the first export (when using defaults).

@pichlermarc pichlermarc added bug Something isn't working triage priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc and removed triage labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc
Projects
None yet
1 participant