workaround for bug/behaviour in otlp-metrics-exporter #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
is this workaround confirmed to work? |
|
just saw the comment about it being an otel bug when the token is undefined. yes, go ahead and pump the last place of every version please |
|
after this is merged, no re-install is necessary, just a manual "sudo philbot_restart" will do the trick if you dont wanna wait until its auto-updating itself. |
moflwi
force-pushed
the
otlp-metricexport-crash
branch
from
e0ea32a to
74bc310
Compare
plengauer
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if reading from an env returns the value undefined and assigning the string the value undefined, so the otlp-metrics doesn't crash until fix in the package is applied.
Worked locally for both services (no load/requests, but was reproducible on simple docker run).
Related issue: open-telemetry/opentelemetry-js#4541