Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL_SEMCONV_STABILITY_OPT_IN not working #5103

Closed
msvechla opened this issue Oct 31, 2024 · 3 comments
Closed

OTEL_SEMCONV_STABILITY_OPT_IN not working #5103

msvechla opened this issue Oct 31, 2024 · 3 comments
Assignees
Labels
bug Something isn't working pkg:instrumentation-http priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect

Comments

@msvechla
Copy link

What happened?

Steps to Reproduce

  • use the latest experimental/v0.54.0 instrumentation
  • add environment variable OTEL_SEMCONV_STABILITY_OPT_IN=http
  • observe http client/server traces

Expected Result

Span attributes follow stable semantic conventions, e.g:

http.response.status_code: 200

Actual Result

Span attributes follow old semantic conventions, e.g:

http.status_code: 200

Additional Details

We are using the OpenTelemetry Operator and Auto-Instrumentation for NodeJS on the latest version.
The environment variable OTEL_SEMCONV_STABILITY_OPT_IN=http is set for the workloads.

CleanShot 2024-10-31 at 11 36 08

You can see that the correct @opentelemetry/instrumentation-http is used with a version that should support the new semantic conventions.

Do you have any idea on what is going wrong here? Thanks a lot for your support!

OpenTelemetry Setup Code

we are using the latest https://github.com/open-telemetry/opentelemetry-operator/pkgs/container/opentelemetry-operator%2Fautoinstrumentation-nodejs/296344892?tag=0.54.0

package.json

No response

Relevant log output

No response

@marcopiraccini
Copy link

marcopiraccini commented Nov 8, 2024

@omarHassane
Copy link
Contributor

omarHassane commented Nov 11, 2024

@marcopiraccini @dyladan yea I just had the same issue. looks like the for in is iterating through the indices.
I opened a PR to fix this:
#5137

@pichlermarc pichlermarc added priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect and removed triage labels Nov 12, 2024
@pichlermarc
Copy link
Member

Thanks @omarHassane for opening the PR to fix this - we'll release this next week when #5141 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:instrumentation-http priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
Projects
None yet
Development

No branches or pull requests

5 participants