fix(instrumentation-http): iterating through the OTEL_SEMCONV_STABILITY_OPT_IN content instead of the entry indices #5137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Issue: Setting the
OTEL_SEMCONV_STABILITY_OPT_IN
environment variable doesn't do anything.Bug: In the
http.ts line 112
the for loop iterates throughgetEnv().OTEL_SEMCONV_STABILITY_OPT_IN
but the since it's usingin
the value ofentry
would be the indice of the element in the array (0,1,..) not the value.Fix: Using
of
instead iterates over the values themselves.Please see https://www.typescriptlang.org/docs/handbook/iterators-and-generators.html#forof-vs-forin-statements for more information about the use of
in
vsof
Short description of the changes
Issue: Setting the
OTEL_SEMCONV_STABILITY_OPT_IN
environment variable doesn't do anything.Bug: In the
http.ts line 112
the for loop iterates throughgetEnv().OTEL_SEMCONV_STABILITY_OPT_IN
but the since it's usingin
the value ofentry
would be the indice of the element in the array (0,1,..) not the value.Fix: Using
of
instead iterates over the values themselves.Please see https://www.typescriptlang.org/docs/handbook/iterators-and-generators.html#forof-vs-forin-statements for more information about the use of
in
vsof
Issue
related issue #5103
Type of change
Bug fix
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: