Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid method used for initialising GlobalTracer in opentracing-shim example #988

Closed
sleighzy opened this issue Apr 28, 2020 · 1 comment · Fixed by #990
Closed

Invalid method used for initialising GlobalTracer in opentracing-shim example #988

sleighzy opened this issue Apr 28, 2020 · 1 comment · Fixed by #990
Assignees
@sleighzy
Labels
bug Something isn't working

Comments

@sleighzy
Copy link
Contributor

The OpenTelemetry API was changed to use setGlobalTracerProvider(provider) instead of initGlobalTracerProvider(provider). The change made at the time appears to have broken the opentracing-shim example in the below two files as it also updated the opentracing.initGlobalTracer(shim) call to opentracing.setGlobalTracer(shim).

https://github.com/open-telemetry/opentelemetry-js/pull/839/files#diff-90edab116f366300c10d75d1152a0c90

https://github.com/open-telemetry/opentelemetry-js/pull/839/files#diff-91dfa22f1a98990b3bc83ba65bcdee0a
@sleighzy sleighzy added the bug Something isn't working label Apr 28, 2020
@sleighzy
Copy link
Contributor Author

I'll have a PR for this shortly.

@sleighzy sleighzy mentioned this issue Apr 28, 2020
Merged
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@renovate-bot @rauno56
chore(deps): update github/codeql-action action to v2 (open-telemetry…
a5eecff 
…#988)

Co-authored-by: Rauno Viskus <Rauno56@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleighzy sleighzy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(opentracing-shim): update opentracing shim example
1 participant
@sleighzy