-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent duplicated resource creation #1015
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
May 4, 2020 16:35
Codecov Report
@@ Coverage Diff @@
## master #1015 +/- ##
=======================================
Coverage 95.00% 95.01%
=======================================
Files 212 212
Lines 8813 8827 +14
Branches 796 797 +1
=======================================
+ Hits 8373 8387 +14
Misses 440 440
|
dyladan
approved these changes
May 4, 2020
We might be better off only saving the properties we need (like logger and resource) and not saving a _config property at all. It is unnecessary duplication. |
mayurkale22
added
enhancement
New feature or request
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
May 4, 2020
mayurkale22
reviewed
May 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mwear
approved these changes
May 4, 2020
mayurkale22
approved these changes
May 4, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…en-telemetry#1015) * fix(sns-publish-test-v3): add test for sns.publish for aws sdk v3 * fix(add-header-to-payloads): fix lint errors * fix(sns-publish-test-v3): fix lint problems * fix(sns-publish-test-v3): fix lint problems * fix(sns-publish-test-v3): fix sns version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes