Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: normalize namespace import name for @opentelemetry/api #1016

Merged
merged 1 commit into from
May 5, 2020

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Renamed all namespace import of @opentelemetry/api variable name to api.

@codecov-io
Copy link

codecov-io commented May 5, 2020

Codecov Report

Merging #1016 into master will not change coverage.
The diff coverage is 97.14%.

@@           Coverage Diff           @@
##           master    #1016   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files         212      212           
  Lines        8806     8806           
  Branches      796      796           
=======================================
  Hits         8366     8366           
  Misses        440      440           
Impacted Files Coverage Δ
...ackages/opentelemetry-exporter-jaeger/src/types.ts 100.00% <ø> (ø)
...ackages/opentelemetry-exporter-zipkin/src/types.ts 100.00% <ø> (ø)
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 98.33% <ø> (ø)
...ackages/opentelemetry-metrics/test/Batcher.test.ts 92.59% <ø> (ø)
...lugin-https/test/functionals/https-disable.test.ts 100.00% <ø> (ø)
...kages/opentelemetry-metrics/src/BoundInstrument.ts 92.85% <83.33%> (ø)
packages/opentelemetry-metrics/src/Meter.ts 96.29% <87.50%> (ø)
packages/opentelemetry-core/src/common/time.ts 95.38% <100.00%> (ø)
...ackages/opentelemetry-core/src/trace/TraceState.ts 100.00% <100.00%> (ø)
...ckages/opentelemetry-core/test/common/time.test.ts 100.00% <100.00%> (ø)
... and 10 more

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mayurkale22 mayurkale22 merged commit b1ea454 into open-telemetry:master May 5, 2020
@legendecas legendecas deleted the api branch May 6, 2020 02:46
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants