fix(opentelemetry-core): modify regex to allow future versions #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srjames90
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #1269 +/- ##
=======================================
Coverage 93.01% 93.01%
=======================================
Files 131 131
Lines 3696 3696
Branches 747 747
=======================================
Hits 3438 3438
Misses 258 258
|
srjames90
commented
Jul 1, 2020
mayurkale22
reviewed
Jul 1, 2020
|
I signed it |
|
@srjames90 there is no need to fix the cla/linuxfoundation error. EasyCLA is our new CLA tool and the old one is deprecated. |
Oh, lol thanks |
dyladan
approved these changes
Jul 1, 2020
dyladan
reviewed
Jul 1, 2020
packages/opentelemetry-core/test/context/HttpTraceContext.test.ts
Outdated
Show resolved
Hide resolved
mayurkale22
approved these changes
Jul 1, 2020
dyladan
reviewed
Jul 1, 2020
packages/opentelemetry-core/test/context/HttpTraceContext.test.ts
Outdated
Show resolved
Hide resolved
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes