Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not crash on fetch(new Request(url)) #1274

Merged
merged 4 commits into from
Jul 8, 2020
Merged

fix: do not crash on fetch(new Request(url)) #1274

merged 4 commits into from
Jul 8, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jul 2, 2020

Fixes #1273

@dyladan dyladan added the bug Something isn't working label Jul 2, 2020
@dyladan dyladan mentioned this pull request Jul 2, 2020
Closed
@codecov
Copy link

codecov bot commented Jul 2, 2020 •
edited
Loading

Codecov Report

Merging #1274 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
- Coverage   93.42%   93.42%   -0.01%     
==========================================
  Files         132      132              
  Lines        3755     3754       -1     
  Branches      761      763       +2     
==========================================
- Hits         3508     3507       -1     
  Misses        247      247
Impacted Files Coverage Δ
packages/opentelemetry-metrics/src/Meter.ts 92.30% <100.00%> (-0.38%) ⬇️
packages/opentelemetry-plugin-fetch/src/fetch.ts 96.52% <100.00%> (+0.09%) ⬆️

obecny
obecny approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vmarchaud
vmarchaud approved these changes Jul 4, 2020
View reviewed changes
Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, comment is not a blocker

packages/opentelemetry-plugin-fetch/src/fetch.ts Outdated Show resolved Hide resolved
@mayurkale22 mayurkale22 merged commit 264fb36 into open-telemetry:master Jul 8, 2020
@Flarna Flarna deleted the fix-fetch-request branch July 17, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naseemkullah naseemkullah naseemkullah approved these changes

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@obecny obecny obecny approved these changes

@legendecas legendecas Awaiting requested review from legendecas

@markwolff markwolff Awaiting requested review from markwolff

@mwear mwear Awaiting requested review from mwear

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Cannot assign to read only property 'headers' of object '[object Request]'
5 participants
@dyladan @obecny @vmarchaud @mayurkale22 @naseemkullah