Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): camelCase methods can be double patched #1289

Merged
merged 5 commits into from
Jul 18, 2020

Conversation

markwolff
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • RPC Methods defined with leading lowercase character, e.g. camelCaseMethod will be patched twice, leading to unexpected patching behavior.

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #1289 into master will decrease coverage by 0.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
- Coverage   93.04%   92.29%   -0.75%     
==========================================
  Files         137      180      +43     
  Lines        3794     4490     +696     
  Branches      784      932     +148     
==========================================
+ Hits         3530     4144     +614     
- Misses        264      346      +82     
Impacted Files Coverage Δ
packages/opentelemetry-api/src/api/global-utils.ts
...ges/opentelemetry-metrics/src/SumObserverMetric.ts
packages/opentelemetry-metrics/src/Metric.ts
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts
...pentelemetry-api/src/context/propagation/setter.ts
...ackages/opentelemetry-api/src/metrics/NoopMeter.ts
...telemetry-node/src/instrumentation/PluginLoader.ts
...elemetry-semantic-conventions/src/trace/general.ts
...rces/src/platform/node/detectors/AwsEc2Detector.ts
...s/opentelemetry-metrics/src/ValueObserverMetric.ts
... and 306 more

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when lint is fixed

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dyladan dyladan added the bug Something isn't working label Jul 15, 2020
@dyladan
Copy link
Member

dyladan commented Jul 15, 2020

@open-telemetry/javascript-maintainers all maintainers have approved this, I think we can merge it?

@mayurkale22 mayurkale22 merged commit bd03c89 into open-telemetry:master Jul 18, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
…pen-telemetry#1289)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC plugin issue | TypeError: Cannot read property 'replace' of undefined
4 participants