-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grpc): camelCase methods can be double patched #1289
fix(grpc): camelCase methods can be double patched #1289
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
- Coverage 93.04% 92.29% -0.75%
==========================================
Files 137 180 +43
Lines 3794 4490 +696
Branches 784 932 +148
==========================================
+ Hits 3530 4144 +614
- Misses 264 346 +82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when lint is fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@open-telemetry/javascript-maintainers all maintainers have approved this, I think we can merge it? |
…pen-telemetry#1289) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Which problem is this PR solving?
Short description of the changes
camelCaseMethod
will be patched twice, leading to unexpected patching behavior.