Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding info about collector compatible version, removing duplicated doc after merge #1361

Merged
merged 6 commits into from
Aug 13, 2020

Conversation

obecny
Copy link
Member

@obecny obecny commented Jul 28, 2020

as in title

@obecny obecny added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1361 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1361   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files         145      145           
  Lines        4314     4314           
  Branches      877      877           
=======================================
  Hits         4061     4061           
  Misses        253      253           

Copy link
Member

@naseemkullah naseemkullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nit for collector version (>=)

@dyladan dyladan added document Documentation-related Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) labels Aug 12, 2020
@dyladan
Copy link
Member

dyladan commented Aug 12, 2020

After conflicts resolved this can merge.

@obecny obecny merged commit 878451a into open-telemetry:master Aug 13, 2020
@obecny obecny deleted the readme-collector branch August 13, 2020 02:18
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants