-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing semantic conventions from code coverage #1409
removing semantic conventions from code coverage #1409
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
+ Coverage 94.03% 94.04% +0.01%
==========================================
Files 149 143 -6
Lines 4322 4268 -54
Branches 880 866 -14
==========================================
- Hits 4064 4014 -50
+ Misses 258 254 -4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @vmarchaud please remove the codecov
script altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to provide LGTM and hope you can address @vmarchaud's comment prior to merging.
5232038
to
d5eadf4
Compare
removing semantic conventions from code coverage
We don't need code coverage for just semantic stuff - otherwise this is misleading