Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change documentation URL #1460

Merged
merged 4 commits into from
Aug 25, 2020
Merged

Conversation

confiq
Copy link
Contributor

@confiq confiq commented Aug 24, 2020

Which problem is this PR solving?

  • The documentation URL. I did grep search on the project to find if there are any more wrong URLs but I could not find.

Short description of the changes

  • PR #546 broke URL docs

@confiq confiq changed the title docs(opentelemetry-exporter-zipkin): change documentation URL docs): change documentation URL Aug 24, 2020
@confiq confiq changed the title docs): change documentation URL docs: change documentation URL Aug 24, 2020
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #1460 into master will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1460      +/-   ##
==========================================
- Coverage   93.76%   93.66%   -0.11%     
==========================================
  Files         149      138      -11     
  Lines        4525     4180     -345     
  Branches      939      851      -88     
==========================================
- Hits         4243     3915     -328     
+ Misses        282      265      -17     
Impacted Files Coverage Δ
...lemetry-tracing/src/export/InMemorySpanExporter.ts
packages/opentelemetry-tracing/src/Tracer.ts
...telemetry-tracing/src/export/BatchSpanProcessor.ts
...es/opentelemetry-tracing/src/MultiSpanProcessor.ts
...ges/opentelemetry-tracing/src/NoopSpanProcessor.ts
...elemetry-tracing/src/export/SimpleSpanProcessor.ts
...elemetry-tracing/src/export/ConsoleSpanExporter.ts
packages/opentelemetry-tracing/src/utility.ts
...s/opentelemetry-tracing/src/BasicTracerProvider.ts
packages/opentelemetry-tracing/src/Span.ts
... and 1 more

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@mayurkale22 mayurkale22 merged commit 7ef38a1 into open-telemetry:master Aug 25, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants