Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper histogram boundaries sort #1475

Merged
merged 3 commits into from
Aug 28, 2020

Conversation

AndrewGrachov
Copy link
Contributor

Which problem is this PR solving?

  • Proper sort of histogram boundaries

Short description of the changes

  • Well known javascript behaviour, when array sort is being implemented by lexicographical order, not number,
    so [200, 1000, 300, 1500] instead of [200, 300, 1000, 1500] becomes [1000, 1500, 200, 300]

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #1475 into master will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1475      +/-   ##
==========================================
- Coverage   93.99%   93.80%   -0.19%     
==========================================
  Files         153      148       -5     
  Lines        4659     4389     -270     
  Branches      960      900      -60     
==========================================
- Hits         4379     4117     -262     
+ Misses        280      272       -8     
Impacted Files Coverage Δ
...emetry-metrics/src/export/aggregators/Histogram.ts 100.00% <100.00%> (ø)
...ry-exporter-collector/src/CollectorExporterBase.ts
...kages/opentelemetry-exporter-collector/src/util.ts
.../opentelemetry-exporter-collector/src/transform.ts
...lemetry-exporter-collector/src/transformMetrics.ts
...ages/opentelemetry-exporter-collector/src/types.ts

@dyladan dyladan added the bug Something isn't working label Aug 28, 2020
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayurkale22 mayurkale22 merged commit c5294ba into open-telemetry:master Aug 28, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants