Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jaeger): export ExporterConfig #1478

Merged
merged 5 commits into from
Nov 3, 2020

Conversation

shivkanya9146
Copy link
Contributor

@shivkanya9146 shivkanya9146 commented Aug 30, 2020

Short description of the changes

-Fixes #1443

@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #1478 into master will decrease coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1478      +/-   ##
==========================================
- Coverage   91.53%   91.19%   -0.34%     
==========================================
  Files         155      165      +10     
  Lines        4891     5066     +175     
  Branches     1005     1037      +32     
==========================================
+ Hits         4477     4620     +143     
- Misses        414      446      +32     
Impacted Files Coverage Δ
packages/opentelemetry-resources/src/constants.ts 100.00% <0.00%> (ø)
...ces/src/platform/node/detectors/ProcessDetector.ts 100.00% <0.00%> (ø)
...pentelemetry-core/src/platform/node/environment.ts 100.00% <0.00%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (ø)
...ry-resources/src/platform/node/detect-resources.ts 20.83% <0.00%> (ø)
...ntelemetry-core/src/platform/node/hex-to-base64.ts 100.00% <0.00%> (ø)
...opentelemetry-core/src/platform/node/BasePlugin.ts 81.08% <0.00%> (ø)
packages/opentelemetry-resources/src/Resource.ts 100.00% <0.00%> (ø)
...sources/src/platform/node/detectors/EnvDetector.ts 86.66% <0.00%> (ø)
...opentelemetry-core/src/platform/node/timer-util.ts 50.00% <0.00%> (ø)
... and 3 more

@obecny
Copy link
Member

obecny commented Aug 31, 2020

please fix the description of PR - the link fixes is broken

@dyladan
Copy link
Member

dyladan commented Aug 31, 2020

Title says zipkin but the fix is actually applied to jaeger

@shivkanya9146 shivkanya9146 changed the title chore(zipkin): export ExporterConfig chore(jaeger): export ExporterConfig Sep 8, 2020
@shivkanya9146
Copy link
Contributor Author

Title says zipkin but the fix is actually applied to jaeger

Done

@dyladan dyladan merged commit b1e2bed into open-telemetry:master Nov 3, 2020
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* chore: document unmaintained components in yml

* chore: add @seemk as component owner for instrumentation-bunyan

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* chore: add @seemk as component owner for instrumentation-net

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* chore: add @haddasbronfman as component owner for instrumentation-mysql2

* Update .github/component_owners.yml

* Apply suggestions from code review

* Add @seemk ownerships

---------

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JaegerExporter] ExporterConfig needs to be exported since it is API
4 participants