-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): rename ProbabilitySampler to TraceIdRatioBasedSampler #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TraceIdRatioBasedSamplers are determinist samplers based on trace ids.
legendecas
requested review from
dyladan,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
October 1, 2020 17:14
Codecov Report
@@ Coverage Diff @@
## master #1562 +/- ##
==========================================
+ Coverage 92.74% 92.93% +0.18%
==========================================
Files 146 156 +10
Lines 4593 4870 +277
Branches 943 988 +45
==========================================
+ Hits 4260 4526 +266
- Misses 333 344 +11
|
legendecas
force-pushed
the
trace-id-ratio-based
branch
from
October 2, 2020 02:49
54ec159
to
35ec738
Compare
dyladan
approved these changes
Oct 2, 2020
obecny
approved these changes
Oct 2, 2020
vmarchaud
approved these changes
Oct 2, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…te (open-telemetry#1562) * fix(redis-4): omit credentials from db.connection_string span attribute * Reconstruct non-sensitive db.connection_string using built-in URL.href * style(redis-4): Fix code style according to community standards * fix(redis-4): Log error on connection string sanitization failure --------- Co-authored-by: Amir Blum <amirgiraffe@gmail.com> Co-authored-by: Haddas Bronfman <85441461+haddasbronfman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TraceIdRatioBasedSampler are determinist samplers based on trace ids.
Which problem is this PR solving?
Short description of the changes
TraceIdRatioBased
sampler with a given sampling rate also sample all traces that anyTraceIdRatioBased
sampler with a lower sampling rate would sample.Note: per the time the PR is filed, the implementation detail of the sampler regarding the trace ids on spec is not yet determined. Though there will be no API changes regarding the new spec on this part, so it is safe to land the API with this primitive reminder based implemention.
This is a breaking change.