fix: histogram aggregator lastUpdateTime #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGrachov
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
|
tests are on the way |
Codecov Report
@@ Coverage Diff @@
## master #1567 +/- ##
==========================================
- Coverage 92.93% 92.54% -0.40%
==========================================
Files 156 129 -27
Lines 4870 3406 -1464
Branches 988 625 -363
==========================================
- Hits 4526 3152 -1374
+ Misses 344 254 -90 |
|
test is ready |
dyladan
approved these changes
Oct 2, 2020
obecny
reviewed
Oct 2, 2020
packages/opentelemetry-metrics/test/export/aggregators/Histogram.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-metrics/src/export/aggregators/Histogram.ts
Outdated
Show resolved
Hide resolved
|
fixed. probably worth to squash on merge |
AndrewGrachov
changed the title
AndrewGrachov
changed the title
…nto fix-histogram-update-time
legendecas
approved these changes
Oct 4, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…e instead (open-telemetry#1567) * feat(koa): Skip update HTTP's span name and update RpcMetadata's route instead * make the logic of rpcMetadata.route the same as previously * Remove unused variable --------- Co-authored-by: Haddas Bronfman <85441461+haddasbronfman@users.noreply.github.com> Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Timestamp in prometheus export is not updated over time
Short description of the changes