-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simplify active span logic #1589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
added
release:required-for-ga
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Oct 10, 2020
mwear
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
October 10, 2020 04:25
Codecov Report
@@ Coverage Diff @@
## master #1589 +/- ##
==========================================
+ Coverage 91.41% 91.44% +0.03%
==========================================
Files 165 165
Lines 5055 5052 -3
Branches 1035 1034 -1
==========================================
- Hits 4621 4620 -1
+ Misses 434 432 -2
|
vmarchaud
approved these changes
Oct 10, 2020
dyladan
approved these changes
Oct 13, 2020
obecny
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I think there is one typo
This method doesn't really make sense since we wrap a span context in a span on extract. Getting the context from the current span is preferred replacement.
Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
mwear
force-pushed
the
default-span-on-extract
branch
from
October 14, 2020 01:13
04433ba
to
feb1fcc
Compare
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
This PR simplifies the active span logic by only storing a span in the active context. Instead of storing plain span contexts in a context, they are wrapped in a NoopSpan on extract.
setExtractedSpanContext
API method was updated to wrap the extracted span context in a NoopSpan before storing it in a context.getExtractedSpanContext
method was removed, as this should now be done by accessing the context of the current span.cc: @vmarchaud - This work might be a prerequisite for #1552.