-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove explicit parent option #1612
chore: remove explicit parent option #1612
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1612 +/- ##
==========================================
- Coverage 91.22% 91.19% -0.03%
==========================================
Files 165 165
Lines 5070 5066 -4
Branches 1039 1037 -2
==========================================
- Hits 4625 4620 -5
- Misses 445 446 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we bump this https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-api/src/api/global-utils.ts#L68 to ensure it doesnt cause a problem ?
packages/opentelemetry-api/test/noop-implementations/noop-tracer.test.ts
Show resolved
Hide resolved
done @vmarchaud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I understand that Opentelemetry has not v1 yet but changes like that which brake current usage of parent context should be a little bit more discussed and at least explained in docs how I should now create child span if I don't have Context class instance that with appropriate methods on it, only I'm using Opentelemetry with Google Cloud Trace and I have varial microservices. Requests are processed with many protocols from HTTP, RPC to async PubSub messaging. I pass my span context as simple JSON that I can use as a universal way of creating child spans. At least I used to use it like that because now I can't and I need to stick with @opentelemetry/0.12.0. |
@LukaszKuciel There was quite a discussion there: open-telemetry/opentelemetry-specification#875 Please note the OpenTelemetry Js follows the spec in such topics. There were also a lot discussions about the context concept, what it should be used for,... Just browse/read through the closed issues/PRs in spec repo to get details. But I agree that we could improve regarding docs. |
I spent some time reading throughout issues and PRs, change log, etc.. You're doing great job with whole project I really appreciate it. I'm only afraid based on my experience working with it on a complex event-driven architecture that without documentation it's really really hard and takes a lot of time. |
Fixes #1611