Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: boundaries option propagation in ValueRecorder Metric #1628

Conversation

AndrewGrachov
Copy link
Contributor

@AndrewGrachov AndrewGrachov commented Oct 28, 2020

Which problem is this PR solving?

Short description of the changes

  • Set boundaries on valueRecorder creation

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #1628 (f3d34cf) into master (deb0cc7) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
- Coverage   91.50%   91.37%   -0.14%     
==========================================
  Files          71      165      +94     
  Lines        1907     5053    +3146     
  Branches      397     1045     +648     
==========================================
+ Hits         1745     4617    +2872     
- Misses        162      436     +274     
Impacted Files Coverage Δ
...ry-exporter-prometheus/src/PrometheusSerializer.ts 98.01% <100.00%> (ø)
packages/opentelemetry-metrics/src/Metric.ts 97.36% <100.00%> (ø)
...ackages/opentelemetry-exporter-jaeger/src/types.ts 100.00% <0.00%> (ø)
...s/opentelemetry-plugin-grpc-js/src/client/index.ts 100.00% <0.00%> (ø)
...elemetry-exporter-zipkin/src/platform/node/util.ts 96.66% <0.00%> (ø)
packages/opentelemetry-plugin-grpc-js/src/utils.ts 96.15% <0.00%> (ø)
...ontext-async-hooks/src/AsyncHooksContextManager.ts 100.00% <0.00%> (ø)
...entelemetry-context-base/src/NoopContextManager.ts 100.00% <0.00%> (ø)
packages/opentelemetry-metrics/src/export/types.ts 100.00% <0.00%> (ø)
...lemetry-tracing/src/export/InMemorySpanExporter.ts 100.00% <0.00%> (ø)
... and 91 more

@AndrewGrachov
Copy link
Contributor Author

prometheus exporter test left

@AndrewGrachov
Copy link
Contributor Author

OK,now its ready.
@obecny @dyladan @vmarchaud pls review

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@dyladan dyladan added the enhancement New feature or request label Nov 11, 2020
@dyladan dyladan merged commit ceba9be into open-telemetry:master Nov 11, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@opentelemetry/metrics: The option "boundaries" for metrics is not propagated to the HistogramAggregator
4 participants