-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: boundaries option propagation in ValueRecorder Metric #1628
Merged
dyladan
merged 11 commits into
open-telemetry:master
from
AndrewGrachov:fix-set-metric-boundaries-option-1626
Nov 11, 2020
Merged
fix: boundaries option propagation in ValueRecorder Metric #1628
dyladan
merged 11 commits into
open-telemetry:master
from
AndrewGrachov:fix-set-metric-boundaries-option-1626
Nov 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGrachov
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
October 28, 2020 04:50
…nto fix-set-metric-boundaries-option-1626
Codecov Report
@@ Coverage Diff @@
## master #1628 +/- ##
==========================================
- Coverage 91.50% 91.37% -0.14%
==========================================
Files 71 165 +94
Lines 1907 5053 +3146
Branches 397 1045 +648
==========================================
+ Hits 1745 4617 +2872
- Misses 162 436 +274
|
prometheus exporter test left |
OK,now its ready. |
…nto fix-set-metric-boundaries-option-1626
obecny
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
vmarchaud
approved these changes
Nov 4, 2020
dyladan
approved these changes
Nov 4, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
fix @opentelemetry/metrics: The option "boundaries" for metrics is not propagated to the HistogramAggregator #1626
Short description of the changes