Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: eslint - fix unused vars warnings, add precommit lint - part 1 #1636

Merged
merged 4 commits into from
Nov 2, 2020

Conversation

AndrewGrachov
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Stub classes methods arguments were prefixed with "_". Unused vars - deleted. Now this rule will throw error

Also, precommit lint hook introduced

package.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #1636 into master will decrease coverage by 0.10%.
The diff coverage is 84.78%.

@@            Coverage Diff             @@
##           master    #1636      +/-   ##
==========================================
- Coverage   91.32%   91.22%   -0.11%     
==========================================
  Files         161      165       +4     
  Lines        4829     5070     +241     
  Branches      975     1039      +64     
==========================================
+ Hits         4410     4625     +215     
- Misses        419      445      +26     
Impacted Files Coverage Δ
...ges/opentelemetry-metrics/src/export/Controller.ts 45.45% <0.00%> (ø)
...s/opentelemetry-metrics/src/export/NoopExporter.ts 25.00% <0.00%> (ø)
...ckages/opentelemetry-core/src/common/NoopLogger.ts 60.00% <50.00%> (ø)
...ges/opentelemetry-core/src/common/ConsoleLogger.ts 95.00% <75.00%> (ø)
...ackages/opentelemetry-api/src/metrics/NoopMeter.ts 87.69% <80.00%> (ø)
...i/src/context/propagation/NoopTextMapPropagator.ts 75.00% <100.00%> (ø)
packages/opentelemetry-api/src/trace/NoopLogger.ts 100.00% <100.00%> (ø)
packages/opentelemetry-api/src/trace/NoopSpan.ts 100.00% <100.00%> (ø)
packages/opentelemetry-api/src/trace/NoopTracer.ts 100.00% <100.00%> (ø)
...entelemetry-context-base/src/NoopContextManager.ts 100.00% <100.00%> (ø)
... and 12 more

@AndrewGrachov AndrewGrachov changed the title chore: eslint - fix unused vars warnings, add lint staged - part 1 chore: eslint - fix unused vars warnings, add precommit lint - part 1 Oct 28, 2020
@dyladan
Copy link
Member

dyladan commented Oct 29, 2020

Thank you for starting this process. All the warnings have been driving me crazy 😜

eslint.config.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@dyladan dyladan merged commit 53d2b51 into open-telemetry:master Nov 2, 2020
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants