-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: eslint - fix unused vars warnings, add precommit lint - part 1 #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGrachov
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
October 28, 2020 17:18
AndrewGrachov
commented
Oct 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #1636 +/- ##
==========================================
- Coverage 91.32% 91.22% -0.11%
==========================================
Files 161 165 +4
Lines 4829 5070 +241
Branches 975 1039 +64
==========================================
+ Hits 4410 4625 +215
- Misses 419 445 +26
|
AndrewGrachov
changed the title
chore: eslint - fix unused vars warnings, add lint staged - part 1
chore: eslint - fix unused vars warnings, add precommit lint - part 1
Oct 28, 2020
dyladan
approved these changes
Oct 29, 2020
Thank you for starting this process. All the warnings have been driving me crazy 😜 |
obecny
reviewed
Oct 30, 2020
mayurkale22
approved these changes
Nov 1, 2020
vmarchaud
approved these changes
Nov 1, 2020
…nto lint-fix-1093
naseemkullah
approved these changes
Nov 1, 2020
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Also, precommit lint hook introduced