Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert fetch plugin to instrumentation #1796

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Conversation

obecny
Copy link
Member

@obecny obecny commented Jan 7, 2021

Which problem is this PR solving?

Short description of the changes

  • Convert fetch plugin to instrumentation
  • Updated to use semantic conventions to avoid duplicates from local attributes definitions (HttpAttribute)

@obecny obecny added the enhancement New feature or request label Jan 7, 2021
@obecny obecny self-assigned this Jan 7, 2021
@obecny obecny changed the title Fetch Convert fetch plugin to instrumentation Jan 7, 2021
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #1796 (6ae8908) into master (4ab9465) will decrease coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1796      +/-   ##
==========================================
- Coverage   92.49%   92.10%   -0.39%     
==========================================
  Files         173      159      -14     
  Lines        6019     5169     -850     
  Branches     1287     1110     -177     
==========================================
- Hits         5567     4761     -806     
+ Misses        452      408      -44     
Impacted Files Coverage Δ
...ry-exporter-collector/src/CollectorExporterBase.ts
...lemetry-exporter-collector/src/transformMetrics.ts
...mentation-xml-http-request/src/enums/EventNames.ts
.../opentelemetry-exporter-collector/src/transform.ts
...emetry-instrumentation-xml-http-request/src/xhr.ts
...ackages/opentelemetry-web/src/WebTracerProvider.ts
...ntelemetry-web/src/enums/PerformanceTimingNames.ts
...kages/opentelemetry-exporter-collector/src/util.ts
packages/opentelemetry-web/src/utils.ts
packages/opentelemetry-web/src/types.ts
... and 2 more

@dyladan
Copy link
Member

dyladan commented Jan 8, 2021

I thought we agreed to keep both plugin and instr until the new loader was ready?

@obecny
Copy link
Member Author

obecny commented Jan 8, 2021

I thought we agreed to keep both plugin and instr until the new loader was ready?

for node yes, for web it is fully compatible it will have just a different name, see XMLHTTPRequest it is the same

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks

@obecny obecny merged commit 5862bc0 into open-telemetry:master Jan 12, 2021
@obecny obecny deleted the fetch branch January 12, 2021 14:11
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
…metry#1796)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert fetch plugin to instrumentation
4 participants