-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prometheus exporter host and port env vars #1857
Conversation
4ed7358
to
1090a0a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1857 +/- ##
==========================================
+ Coverage 92.45% 92.78% +0.32%
==========================================
Files 165 182 +17
Lines 5463 6400 +937
Branches 1152 1354 +202
==========================================
+ Hits 5051 5938 +887
- Misses 412 462 +50
|
1090a0a
to
fb1810e
Compare
fb1810e
to
239bfdd
Compare
6530e9f
to
65b7349
Compare
packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts
Outdated
Show resolved
Hide resolved
a5e90c4
to
785ed66
Compare
packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts
Outdated
Show resolved
Hide resolved
@naseemkullah FYI lint is failing |
b8b7b86
to
5e68f66
Compare
Tests keep timing out. Anyone know why? |
1deae21
to
49642fa
Compare
I tried to run the exporter-prometheus tests locally and quite of them fail and test process is not ended. I assume there is some leftover server avoiding this. Is there anything special needed to run them local? |
Thanks! I must have forgotten to shutdown after tests, stay tuned! |
The first failing test for me is You could move the |
Thanks for the tip! |
c6b4101
to
d407fb1
Compare
d407fb1
to
22b18d2
Compare
Signed-off-by: naseemkullah <naseem@transit.app>
22b18d2
to
0455232
Compare
Signed-off-by: naseemkullah naseem@transit.app
Which problem is this PR solving?
solves #1852
Short description of the changes
Added env vars for prometheux expoter host and port. Defaults are '0.0.0.0' (all addresses) and 9464 respectively.