Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all gitter links and replace with dicussions #1866

Merged
merged 4 commits into from
Jan 27, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jan 25, 2021

Now that we have switched from gitter to discussions, I would like to encourage users to ask questions there.

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #1866 (8d817ce) into main (26b2c4c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
- Coverage   92.66%   92.65%   -0.02%     
==========================================
  Files         174      174              
  Lines        6030     6030              
  Branches     1278     1278              
==========================================
- Hits         5588     5587       -1     
- Misses        442      443       +1     
Impacted Files Coverage Δ
...ry-context-zone-peer-dep/src/ZoneContextManager.ts 85.18% <ø> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

Copy link
Member

@johnbley johnbley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I grepped and noticed that you missed a reference in CONTRIBUTING.md:

you can ask for a review on Gitter channel

@dyladan dyladan merged commit 1eed360 into open-telemetry:main Jan 27, 2021
@dyladan dyladan deleted the gitter-discussions branch January 27, 2021 14:35
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
…metry#1866)

* chore: remove all gitter links and replace with dicussions

* chore: remove reference to gitter in contributing.md
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
…metry#1866)

* chore: remove all gitter links and replace with dicussions

* chore: remove reference to gitter in contributing.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants