Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): pin dependency @opentelemetry/api to 0.18.0 - autoclosed #1964

Closed
wants to merge 1 commit into from
Closed

fix(deps): pin dependency @opentelemetry/api to 0.18.0 - autoclosed #1964

wants to merge 1 commit into from

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Feb 26, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change
@opentelemetry/api dependencies pin ^0.18.0 -> 0.18.0

📌 Important: Renovate will wait until you have merged this Pin PR before creating any upgrade PRs for the affected packages. Add the preset :preserveSemverRanges to your config if you instead don't wish to pin dependencies.


Renovate configuration

📅 Schedule: "before 3am on Friday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@forking-renovate
Copy link

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻️ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you check the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated mkdirp-promise@5.0.1: This package is broken and no longer maintained. 'mkdirp' itself supports promises now, please switch to that.
npm WARN @octokit/plugin-request-log@1.0.3 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.

lerna notice cli v3.22.1
lerna info Bootstrapping 39 packages
lerna info Installing external dependencies

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #1964 (393a674) into main (6540b54) will decrease coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
- Coverage   92.92%   92.56%   -0.37%     
==========================================
  Files         152      135      -17     
  Lines        5922     4988     -934     
  Branches     1245     1045     -200     
==========================================
- Hits         5503     4617     -886     
+ Misses        419      371      -48     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️
packages/opentelemetry-web/src/utils.ts
...ackages/opentelemetry-web/src/WebTracerProvider.ts
...kages/opentelemetry-web/src/StackContextManager.ts
...ages/opentelemetry-exporter-collector/src/types.ts
...emetry-instrumentation-xml-http-request/src/xhr.ts
...lemetry-exporter-collector/src/transformMetrics.ts
.../opentelemetry-exporter-collector/src/transform.ts
...rumentation/src/platform/browser/old/autoLoader.ts
...-instrumentation-fetch/src/enums/AttributeNames.ts
... and 8 more

@@ -8,8 +8,8 @@
"test:backcompat": "tsc --noEmit index.ts"
},
"dependencies": {
"@opentelemetry/sdk-node": "^0.17.0",
"@opentelemetry/tracing": "^0.17.0"
"@opentelemetry/sdk-node": "0.17.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this seems to be strange. As far as I know we want to pin dev dependencies but not prod dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it pins dependencies outside the monorepo by default

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but lerna.json tells that backwards-compatability/* is part of the project.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's smart enough to read the lerna config. It might just be looking in the packages directory.

@renovate-bot renovate-bot changed the title fix(deps): pin dependencies fix(deps): pin dependency @opentelemetry/api to 0.18.0 Mar 1, 2021
@@ -64,7 +64,7 @@
"typescript": "4.1.3"
},
"dependencies": {
"@opentelemetry/api": "^0.18.0",
"@opentelemetry/api": "0.18.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the ^ was there already before the PR to 0.18.0 was merged.
@dyladan any hints why renovate-bot prefers a fixed dependency here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think because the API is no longer in the monorepo. Behavior should be restored to the old version by #1981

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, shimmer is also pinned.

@renovate-bot renovate-bot changed the title fix(deps): pin dependency @opentelemetry/api to 0.18.0 fix(deps): pin dependency @opentelemetry/api to 0.18.0 - autoclosed Mar 11, 2021
@renovate-bot renovate-bot deleted the renovate/pin-dependencies branch March 11, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants