-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): pin dependency @opentelemetry/api to 0.18.0 - autoclosed #1964
fix(deps): pin dependency @opentelemetry/api to 0.18.0 - autoclosed #1964
Conversation
|
@@ -8,8 +8,8 @@ | |||
"test:backcompat": "tsc --noEmit index.ts" | |||
}, | |||
"dependencies": { | |||
"@opentelemetry/sdk-node": "^0.17.0", | |||
"@opentelemetry/tracing": "^0.17.0" | |||
"@opentelemetry/sdk-node": "0.17.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this seems to be strange. As far as I know we want to pin dev dependencies but not prod dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it pins dependencies outside the monorepo by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but lerna.json tells that backwards-compatability/*
is part of the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's smart enough to read the lerna config. It might just be looking in the packages directory.
@@ -64,7 +64,7 @@ | |||
"typescript": "4.1.3" | |||
}, | |||
"dependencies": { | |||
"@opentelemetry/api": "^0.18.0", | |||
"@opentelemetry/api": "0.18.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the ^
was there already before the PR to 0.18.0 was merged.
@dyladan any hints why renovate-bot prefers a fixed dependency here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think because the API is no longer in the monorepo. Behavior should be restored to the old version by #1981
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, shimmer is also pinned.
This PR contains the following updates:
^0.18.0
->0.18.0
📌 Important: Renovate will wait until you have merged this Pin PR before creating any upgrade PRs for the affected packages. Add the preset
:preserveSemverRanges
to your config if you instead don't wish to pin dependencies.Renovate configuration
📅 Schedule: "before 3am on Friday" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by WhiteSource Renovate. View repository job log here.