-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(propagator-jaeger): zero pad extracted trace id to 32 characters #1986
fix(propagator-jaeger): zero pad extracted trace id to 32 characters #1986
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #1986 +/- ##
=======================================
Coverage 93.05% 93.05%
=======================================
Files 154 154
Lines 5975 5976 +1
Branches 1246 1246
=======================================
+ Hits 5560 5561 +1
Misses 415 415
|
packages/opentelemetry-propagator-jaeger/test/JaegerHttpTracePropagator.test.ts
Outdated
Show resolved
Hide resolved
Sorry this slipped through the cracks and it's been so long to get reviews. Implementation looks good but I think the test isn't actually testing your change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI padStart is not supported in IE 11 but luckily from what I checked the support has been already dropped My Microsoft Team in last year and on 13th of April (very soon) Windows 10 will get Edge as security update. End of IE11 - small thing to celebrate :)
Which problem is this PR solving?
Fixes #1983
Short description of the changes
Ensures the Jaeger propagator context extraction conforms to the Jaeger trace context specification. Specifically, when received trace id shorter that 32 characters, it will now be zero-padded to 32 characters.