remove plugins #2081
remove plugins #2081
Conversation
…moving base abstract class
obecny
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2081 +/- ##
==========================================
- Coverage 93.08% 92.55% -0.53%
==========================================
Files 154 133 -21
Lines 5999 4848 -1151
Branches 1258 1000 -258
==========================================
- Hits 5584 4487 -1097
+ Misses 415 361 -54
|
| @@ -162,7 +162,7 @@ myPLugin.enable(); | |||
| Successor of loading plugins through TracerProvider "plugins" option. | |||
| It also supersedes PluginLoader for node. The old configurations usually looks like | |||
|
|
|||
| ### NODE - old way using TracerProvider | |||
| ### NODE - old way using TracerProvider - not available anymore | |||
There was a problem hiding this comment.
Should we remove this is it is no longer available?
There was a problem hiding this comment.
I had hard times to decide whether to remove it or it should remain for some time so when people will be upgrading they can at least compare what has changed. That was the reason I left it but really not sure what is better from user perspective :/, can remove it as well
There was a problem hiding this comment.
I think it's ok to keep it for a while. But I think we should change it to something like removed since 0.19.0.
| "@opentelemetry/plugin-express": "^0.14.0", | ||
| "@opentelemetry/plugin-http": "^0.18.2", | ||
| "@opentelemetry/plugin-https": "^0.18.2", | ||
| "@opentelemetry/instrumentation-express": "^0.15.0", |
There was a problem hiding this comment.
Not needed in this PR - but I think we should get rid of dependencies to contrib in this repo.
Which problem is this PR solving?
Short description of the changes