-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(env): update default value for span's attributes/links/events count #1675 #2098
chore(env): update default value for span's attributes/links/events count #1675 #2098
Conversation
59d3036
to
9a22011
Compare
Codecov Report
@@ Coverage Diff @@
## main #2098 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 137 137
Lines 4915 4915
Branches 1015 1015
=======================================
Hits 4559 4559
Misses 356 356
|
I added breaking label, but i'm actually not sure. It obviously doesn't break any users but it might change the output of the telemetry for high-volume users |
never too safe :) |
@vmarchaud Does it makes sense to add info about it to upgrade guidelines? |
I dont think since we didn't change the env vars, just their values. If users used them that don't impact them |
Updating default values to respect the spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md#span-collection-limits