Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(env): update default value for span's attributes/links/events count #1675 #2098

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

vmarchaud
Copy link
Member

@vmarchaud vmarchaud force-pushed the env-span-sdk-default branch from 59d3036 to 9a22011 Compare April 11, 2021 08:38
@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #2098 (a35d69a) into main (5dbe53a) will not change coverage.
The diff coverage is n/a.

❗ Current head a35d69a differs from pull request most recent head 6b57817. Consider uploading reports for the commit 6b57817 to get more accurate results

@@           Coverage Diff           @@
##             main    #2098   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         137      137           
  Lines        4915     4915           
  Branches     1015     1015           
=======================================
  Hits         4559     4559           
  Misses        356      356           
Impacted Files Coverage Δ
...ckages/opentelemetry-core/src/utils/environment.ts 100.00% <ø> (ø)

@dyladan
Copy link
Member

dyladan commented Apr 12, 2021

I added breaking label, but i'm actually not sure. It obviously doesn't break any users but it might change the output of the telemetry for high-volume users

@vmarchaud
Copy link
Member Author

I added breaking label, but i'm actually not sure. It obviously doesn't break any users but it might change the output of the telemetry for high-volume users

never too safe :)

@vmarchaud vmarchaud merged commit 2260dd6 into open-telemetry:main Apr 12, 2021
@vmarchaud vmarchaud deleted the env-span-sdk-default branch April 12, 2021 18:08
@jtmalinowski
Copy link
Contributor

@vmarchaud Does it makes sense to add info about it to upgrade guidelines?

@vmarchaud
Copy link
Member Author

Does it makes sense to add info about it to upgrade guidelines?

I dont think since we didn't change the env vars, just their values. If users used them that don't impact them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants