-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): support cumulative, delta, and pass-through exporters #2118
chore(deps): support cumulative, delta, and pass-through exporters #2118
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2118 +/- ##
==========================================
+ Coverage 92.75% 92.77% +0.01%
==========================================
Files 140 140
Lines 4998 4997 -1
Branches 1032 1028 -4
==========================================
Hits 4636 4636
+ Misses 362 361 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good, quite comment though
8dfbabb
to
eb30485
Compare
The mentioned issue is still opened for quite long time already. Does this mean the decision / spec is not yet final ? |
Currently it's not working in JS lib. This code in collector drop every delta metric(counter) https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/prometheusexporter/accumulator.go#L238-L241 Go lib use same logic(AGGREGATION_TEMPORALITY_CUMULATIVE by default) and option for use delta. This PR still provide option use AGGREGATION_TEMPORALITY_DELTA, but fix mainstream flow(JS=>collector=> prometheus). Without this PR opentelemetry-js useless with collector and prometheus |
FYI: need to check something, will get back to this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Which problem is this PR solving?
open-telemetry/opentelemetry-specification#731
Short description of the changes
Use AGGREGATION_TEMPORALITY_CUMULATIVE by default for all metrics and add option for pass AGGREGATION_TEMPORALITY on meter creating. Now counter meter can be work with js => collector => prometheus flow