Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GTS and prettier #2204

Merged
merged 10 commits into from
May 19, 2021
Merged

Remove GTS and prettier #2204

merged 10 commits into from
May 19, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 13, 2021

Some lint rules updated without a minor version change it seems causing other PRs to fail unless you do a full clean and bootstrap. This fixes it for everyone.

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #2204 (604235d) into main (cc44db1) will not change coverage.
The diff coverage is n/a.

❗ Current head 604235d differs from pull request most recent head b7c48c4. Consider uploading reports for the commit b7c48c4 to get more accurate results

@@           Coverage Diff           @@
##             main    #2204   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files          53       53           
  Lines        1726     1726           
  Branches      358      358           
=======================================
  Hits         1617     1617           
  Misses        109      109           

@Flarna
Copy link
Member

Flarna commented May 19, 2021

How do we continue regarding this? There is a new API release now but it seems core is blocked because of lint.

@dyladan
Copy link
Member Author

dyladan commented May 19, 2021

How do we continue regarding this? There is a new API release now but it seems core is blocked because of lint.

We will discuss at SIG today. Core is also blocked on a broken grpc exporter test

@Flarna
Copy link
Member

Flarna commented May 19, 2021

For lint you could cherry pick the workaround (2142a5d) to pin prettier

@dyladan
Copy link
Member Author

dyladan commented May 19, 2021

I just updated this PR to be the minimal set of linting changes to remove gts and prettier

package.json Outdated Show resolved Hide resolved
@dyladan dyladan changed the title chore: lint Remove GTS and prettier May 19, 2021
@dyladan
Copy link
Member Author

dyladan commented May 19, 2021

Merging because test failures are unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants