-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update and make website docs work #2324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svrnm
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
MSNev,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
July 6, 2021 13:33
Codecov Report
@@ Coverage Diff @@
## main #2324 +/- ##
==========================================
+ Coverage 92.36% 92.63% +0.27%
==========================================
Files 128 142 +14
Lines 4243 5091 +848
Branches 866 1047 +181
==========================================
+ Hits 3919 4716 +797
- Misses 324 375 +51
|
…o website-docs-review
…js into website-docs-review
dyladan
approved these changes
Jul 6, 2021
MSNev
approved these changes
Jul 6, 2021
obecny
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jonchurch
reviewed
Jul 6, 2021
Co-authored-by: Jonathan Church <me@jonchurch.com>
vmarchaud
approved these changes
Jul 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the last meeting I looked into updating the website docs so that they are up-to-date with changes made and to work again when people walk through them.