-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: use single quotes everywhere and add a rule to eslint #2351
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2351 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 143 143
Lines 5136 5136
Branches 1052 1052
=======================================
Hits 4771 4771
Misses 365 365
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems quite some formatting rules got lost during removing gts/prettier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Which problem is this PR solving?
The codebase is using a single quote for strings almost everywhere, but there is no such rule in eslint, and some files are written with double quotes and are not fixed automatically by the linter.
Short description of the changes
Add a rule for eslint:
"quotes": [2, "single", { "avoidEscape": true }]
and runlint:fix
to replace double quotes with single quotes where it's not consistent.