-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add quickstart code example #2365
docs: add quickstart code example #2365
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2365 +/- ##
==========================================
- Coverage 92.79% 92.77% -0.02%
==========================================
Files 145 145
Lines 5221 5221
Branches 1070 1070
==========================================
- Hits 4845 4844 -1
- Misses 376 377 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Since this is likely the first documentation users see I would like to have comments that explain what the more confusing parts are doing.
* add comments * make a note about the meta package * use new SemanticResourceAttributes name
Shouldn't |
I initially imported |
i just looked at the readme for |
I would also support this. You can either update this PR or we can review and merge this (since it is an improvement) and do the sdk-node in a sparate PR. Up to you. |
Aha, I'm using it as a meta package, instead of utilizing the actual simplified setup. Got it, and agree that it would be better. Updating now. |
* use sdk-node initializer
Which problem is this PR solving?
Short description of the changes
subjective tradeoffs: