-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix Lint warnings in api-metrics and context-zone-peer-dep #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisabzevari
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
MSNev,
mwear,
naseemkullah,
obecny,
OlivierAlbertini,
rauno56 and
vmarchaud
as code owners
August 3, 2021 14:23
alisabzevari
force-pushed
the
lint-warnings
branch
from
August 3, 2021 14:24
1796970
to
7135ac7
Compare
dyladan
reviewed
Aug 3, 2021
Codecov Report
@@ Coverage Diff @@
## main #2390 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 145 145
Lines 5226 5226
Branches 1071 1071
=======================================
Hits 4849 4849
Misses 377 377
|
alisabzevari
force-pushed
the
lint-warnings
branch
from
August 3, 2021 14:27
7135ac7
to
be6d940
Compare
I removed the last commit because I realized someone else created a PR for that. |
alisabzevari
changed the title
Fix Lint warnings in api-metrics, context-zone-peer-dep, and context-async-hooks
Fix Lint warnings in api-metrics and context-zone-peer-dep
Aug 3, 2021
dyladan
reviewed
Aug 3, 2021
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
dyladan
approved these changes
Aug 4, 2021
dyladan
changed the title
Fix Lint warnings in api-metrics and context-zone-peer-dep
chore: fix Lint warnings in api-metrics and context-zone-peer-dep
Aug 4, 2021
obecny
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice !
Flarna
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1093,
Which problem is this PR solving?
api-metrics
andcontext-zone-peer-dep
packages.Short description of the changes