-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix lint warnings in propagator-jaeger, propagator-b3, resources, and sdk-metrics-base packages #2406
Conversation
@@ -42,7 +42,7 @@ function isValidSampledValue(sampled: TraceFlags | undefined): boolean { | |||
return sampled === TraceFlags.SAMPLED || sampled === TraceFlags.NONE; | |||
} | |||
|
|||
export function parseHeader(header: unknown) { | |||
function parseHeader(header: unknown) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed export
by intuition. Let me know if I did wrong here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the tests pass it's probably fine. It might have been exported for those
e4357c1
to
2439b24
Compare
Codecov Report
@@ Coverage Diff @@
## main #2406 +/- ##
==========================================
- Coverage 92.64% 92.62% -0.03%
==========================================
Files 137 137
Lines 4975 4975
Branches 1048 1048
==========================================
- Hits 4609 4608 -1
- Misses 366 367 +1
|
Which problem is this PR solving?
propagator-jaeger
,propagator-b3
,resources
, andsdk-metrics-base
packages (related to Fix lint warnings #1093)Short description of the changes